Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the faq to call out no_std support #1992

Merged
merged 1 commit into from Aug 29, 2022
Merged

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Aug 29, 2022

Clarifies that the windows-sys crate offers no_std support.

Related: #1989

Copy link
Collaborator

@riverar riverar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no data to suggest this is accurate. The aforementioned issue, for example, demonstrates no_std doesn't work.

@kennykerr
Copy link
Collaborator Author

There's no data to suggest this is accurate. The issue this fixes, for example, demonstrates no_std doesn't work.

This PR just clarifies that the windows-sys crate explicitly supports no_std compilation. This is compiler-enforced but if that's not helpful to include in the FAQ then I'm happy to ditch it.

https://doc.rust-lang.org/reference/names/preludes.html#the-no_std-attribute

Again, this has nothing to do with whether or not the CRT is linked into a given downstream binary. The windows-sys crate has no control over that. Anyway, I'll close this for now.

@kennykerr kennykerr closed this Aug 29, 2022
@ChrisDenton
Copy link
Collaborator

ChrisDenton commented Aug 29, 2022

IMHO, the no_std support for windows-sys is one of the biggest motivating factors for using it instead of windows (the others being compile times and stability).

As Kenny says, this has nothing to do with no-CRT support (which is a very very niche requirement) and in either case that has nothing to do with the windows-sys crate itself. It will support whatever the toolchain supports and has no requirements beyond core.

@riverar riverar reopened this Aug 29, 2022
@riverar riverar merged commit 8f4f65e into master Aug 29, 2022
@riverar riverar deleted the kennykerr-no-std-faq branch August 29, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants